Open gpordeus opened 2 months ago
Attention: Patch coverage is 11.42857%
with 31 lines
in your changes missing coverage. Please review.
Project coverage is 15.82%. Comparing base (
5ff0b99
) to head (147a534
). Report is 69 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@blueorangutan package
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11164
Description
This PR adds the "ownership selection" UI fields to VPC tiers and VPC public IPs.
The "vpcAccess" response attribute was added so the UI can know if the caller has access to the VPC without needing to make a whole new request. This is needed to avoid 404 links (since router.resolve is assembled through API permissions) and so the UI can present the correct public IPs to their possible network tiers (e.g. if the User has tiers of two different VPCs, they can't use one's public IP in the other).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
New tier possible owners' listing
![image](https://github.com/user-attachments/assets/5aab77e1-2105-423b-b976-f937c5cd732e)Tier listing
![image](https://github.com/user-attachments/assets/d952e39d-76e1-403d-b143-762488896a73)User accessing their tier of the Admin's VPC
![image](https://github.com/user-attachments/assets/d952e39d-76e1-403d-b143-762488896a73)Possible owners for new IP
![image](https://github.com/user-attachments/assets/daae5363-358e-4ff9-a3a0-02e23f69cce3)How Has This Been Tested?
Environment with domains Root (with accounts Root Admin and User), Root/1 (with a Domain Admin), Root/A (with a Domain Admin) and Root/A/B (with a Domain Admin and a User). There is a Project in each domain, owned by the respective admins.
How did you try to break this feature and the system with this change?