apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.11k stars 1.11k forks source link

UI: enable project menu on mobile devices #9700

Closed weizhouapache closed 2 months ago

weizhouapache commented 2 months ago

Description

This PR shows project menu on mobile devices

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.11%. Comparing base (a8ab47b) to head (298dbb3). Report is 6 commits behind head on 4.19.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9700 +/- ## =========================================== Coverage 15.11% 15.11% + Complexity 11189 11187 -2 =========================================== Files 5406 5406 Lines 473215 473215 Branches 61384 59430 -1954 =========================================== + Hits 71516 71528 +12 + Misses 393891 393883 -8 + Partials 7808 7804 -4 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9700/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9700/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.76% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9700/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.80% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DaanHoogland commented 2 months ago

@weizhouapache have you tested this/ is it draft? I wonder why this was put in place. Is the reason for that gone?

weizhouapache commented 2 months ago

@weizhouapache have you tested this/ is it draft? I wonder why this was put in place. Is the reason for that gone?

@DaanHoogland to be frank, I have no idea. it was introduced in a very early commit 63e6173a2685166fa9b33dedfa82c401336cb15a by @rohityadavcloud

I used Chrome for testing

image

image

weizhouapache commented 2 months ago

@blueorangutan ui

blueorangutan commented 2 months ago

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

DaanHoogland commented 2 months ago

ok, will test on ff

blueorangutan commented 2 months ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9700 (QA-JID-451)

DaanHoogland commented 2 months ago

ok, will test on ff

Screenshot_20240918-104930

works :+1:

rohityadavcloud commented 2 months ago

Sorry mea culpa - I think it 'could' break on some screens; but LGTM.