set `desplayName` to `name` by default

DaanHoogland commented 2 months ago

Description

This PR prevents a null display name on VMs (see https://github.com/apache/cloudstack/pull/8503#issuecomment-2367394302)

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland commented 2 months ago

@blueorangutan package

blueorangutan commented 2 months ago

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 12.27%. Comparing base (d15a074) to head (7e3bf26).

Files with missing lines	Patch %	Lines
...he/cloudstack/api/command/user/vm/DeployVMCmd.java	0.00%	2 Missing :warning:
...he/cloudstack/api/command/user/vm/UpdateVMCmd.java	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.18 #9719 +/- ## ============================================ - Coverage 12.27% 12.27% -0.01% + Complexity 9336 9333 -3 ============================================ Files 4699 4699 Lines 414691 414695 +4 Branches 51161 52087 +926 ============================================ - Hits 50894 50887 -7 - Misses 357472 357484 +12 + Partials 6325 6324 -1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9719/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9719/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `12.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 2 months ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11176

weizhouapache commented 2 months ago

@DaanHoogland it looks like an UI issue

the API response does have the "displayname" in place. but the name/displayname is not displayed on UI.

as a simple workaround, can we revert #8503 ? @DaanHoogland

DaanHoogland commented 2 months ago

as a simple workaround, can we revert #8503 ? @DaanHoogland

yes, you are right, I'll creat another PR, reapply the changes here, and work on this later.

weizhouapache commented 2 months ago

@blueorangutan ui

blueorangutan commented 2 months ago

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented 2 months ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9719 (QA-JID-456)

apache / cloudstack