apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.1k stars 1.11k forks source link

Bnr resource limits #9765

Open Pearl1594 opened 1 month ago

Pearl1594 commented 1 month ago

Description

This PR addresses:

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 3.70370% with 234 lines in your changes missing coverage. Please review.

Project coverage is 15.77%. Comparing base (046870e) to head (6646d63). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 79 Missing :warning:
...main/java/org/apache/cloudstack/backup/Backup.java 0.00% 15 Missing :warning:
...rg/apache/cloudstack/backup/dao/BackupDaoImpl.java 0.00% 12 Missing :warning:
...main/java/com/cloud/api/query/vo/DomainJoinVO.java 0.00% 12 Missing :warning:
...bernetes/cluster/KubernetesClusterManagerImpl.java 0.00% 10 Missing :warning:
...pache/cloudstack/api/response/AccountResponse.java 0.00% 9 Missing :warning:
...apache/cloudstack/api/response/DomainResponse.java 0.00% 9 Missing :warning:
...pache/cloudstack/api/response/ProjectResponse.java 0.00% 9 Missing :warning:
...rg/apache/cloudstack/backup/NASBackupProvider.java 0.00% 8 Missing :warning:
...org/apache/cloudstack/backup/BackupScheduleVO.java 0.00% 7 Missing :warning:
... and 15 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9765 +/- ## ============================================ - Coverage 15.78% 15.77% -0.02% - Complexity 12551 12552 +1 ============================================ Files 5625 5625 Lines 491972 492423 +451 Branches 63764 59970 -3794 ============================================ + Hits 77662 77683 +21 - Misses 405850 406280 +430 Partials 8460 8460 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9765/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9765/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.03% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9765/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.59% <3.70%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
1.6% Coverage on New Code (required ≥ 40%)
21.3% Duplication on New Code (required ≤ 10%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint