linstor: enable discard for Linstor storage pools

rp- commented 1 month ago

Description

This PR enables qemu discard support for Linstor storage pools

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[x] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested in a Linstor cluster

How did you try to break this feature and the system with this change?

sureshanaparti commented 1 month ago

@blueorangutan package

blueorangutan commented 1 month ago

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 1 month ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11282

sureshanaparti commented 1 month ago

@blueorangutan test

blueorangutan commented 1 month ago

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented 1 month ago

[SF] Trillian test result (tid-11618) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 40689 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9770-t11618-kvm-ol8.zip Smoke tests completed. 91 look OK, 3 have errors, 17 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_list_sec_storage_vm	`Error`	0.01	test_ssvm.py
test_02_list_cpvm_vm	`Error`	0.01	test_ssvm.py
test_03_ssvm_internals	`Error`	0.01	test_ssvm.py
test_04_cpvm_internals	`Error`	0.01	test_ssvm.py
test_05_stop_ssvm	`Error`	0.01	test_ssvm.py
test_06_stop_cpvm	`Error`	0.01	test_ssvm.py
test_07_reboot_ssvm	`Error`	0.01	test_ssvm.py
test_08_reboot_cpvm	`Error`	0.01	test_ssvm.py
test_09_reboot_ssvm_forced	`Error`	0.01	test_ssvm.py
test_10_reboot_cpvm_forced	`Error`	0.01	test_ssvm.py
test_11_destroy_ssvm	`Error`	0.01	test_ssvm.py
test_12_destroy_cpvm	`Error`	0.01	test_ssvm.py
test_13_ss_nfs_version_on_ssvm	`Error`	0.01	test_ssvm.py
test_static_role_account_acls	`Error`	0.01	test_staticroles.py
ContextSuite context=TestVMWareStoragePolicies>:setup	`Error`	0.00	test_storage_policy.py
all_test_templates	`Skipped`	---	test_templates.py
all_test_update_security_group	`Skipped`	---	test_update_security_group.py
all_test_usage_events	`Skipped`	---	test_usage_events.py
all_test_usage	`Skipped`	---	test_usage.py
all_test_vm_autoscaling	`Skipped`	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	`Skipped`	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	`Skipped`	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_snapshot_kvm	`Skipped`	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

sureshanaparti commented 1 month ago

@blueorangutan package

blueorangutan commented 1 month ago

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 1 month ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11294

DaanHoogland commented 1 month ago

@blueorangutan test

blueorangutan commented 1 month ago

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented 1 month ago

[SF] Trillian test result (tid-11625) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 46015 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9770-t11625-kvm-ol8.zip Smoke tests completed. 109 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_01_migrate_VM_and_root_volume	`Error`	80.14	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	52.78	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	47.10	test_vm_life_cycle.py

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 12.27%. Comparing base (bb820f7) to head (ea50ba6). Report is 759 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ervisor/kvm/resource/LibvirtComputingResource.java	0.00%	4 Missing :warning:
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9770 +/- ## ============================================ - Coverage 12.27% 12.27% -0.01% Complexity 9333 9333 ============================================ Files 4699 4699 Lines 414691 414697 +6 Branches 50917 51558 +641 ============================================ Hits 50887 50887 - Misses 357480 357486 +6 Partials 6324 6324 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9770/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9770/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `12.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

apache / cloudstack