apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.1k stars 1.11k forks source link

pre-commit: fix `.cs` files with the `trailing-whitespace` hook #9794

Open jbampton opened 1 month ago

jbampton commented 1 month ago

Description

This PR adds .cs files to the trailing-whitespace pre-commit hook.

This hook auto fixes and removes trailing whitespace when run locally on a users machine.

On the GitHub CI it just runs either pass or fail for now.

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally: pre-commit run --all-files

How did you try to break this feature and the system with this change?

jbampton commented 1 month ago

@blueorangutan package

blueorangutan commented 1 month ago

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.60%. Comparing base (554ea22) to head (60e3797).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9794 +/- ## ============================================ - Coverage 16.60% 16.60% -0.01% + Complexity 12565 12564 -1 ============================================ Files 5235 5235 Lines 460072 460072 Branches 56928 57689 +761 ============================================ - Hits 76408 76407 -1 - Misses 375338 375339 +1 Partials 8326 8326 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9794/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9794/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.60% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 1 month ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11341