apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.1k stars 1.11k forks source link

Fix UI unit test failures #9803

Closed vishesh92 closed 1 month ago

vishesh92 commented 1 month ago

Description

This PR fixes unit test failures introduced in 5ab0a52d66235a0a825d44f74cf7505d0044799c

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 commented 1 month ago

This is already fixed in https://github.com/apache/cloudstack/pull/9798. Closing.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.08%. Comparing base (017cf2c) to head (6836e2d). Report is 2 commits behind head on 4.19.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9803 +/- ## ============================================ - Coverage 15.80% 15.08% -0.72% - Complexity 11199 11204 +5 ============================================ Files 5038 5404 +366 Lines 443875 473417 +29542 Branches 52607 58380 +5773 ============================================ + Hits 70139 71428 +1289 - Misses 365934 394040 +28106 - Partials 7802 7949 +147 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9803/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9803/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9803/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.80% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.