apache / cordova-fetch

Apache Cordova Fetch Library
https://cordova.apache.org/
Apache License 2.0
27 stars 27 forks source link

Work around npm bug when uninstalling old cordova platforms #78

Closed raphinesse closed 5 years ago

raphinesse commented 5 years ago

Motivation and Context

When using npm@>=6.11.0 on Windows, npm uninstall of cordova-android@5.1.1 will leave an empty folder node_modules/cordova-android/node_modules behind. This causes one of our tests to fail but it is very likely an issue with npm. Furthermore this is very unlikely to affect users of cordova-fetch in production.

Description

We just install a later version of cordova-android and cordova-ios in the test. The exact version or even package installed does not really matter, the test just asserts that a package can be installed and then uninstalled .

Testing

CI tests are passing again.