fix: import type definitions from obsolete cordova-plugin-splashscreen

peitschie commented 2 years ago

Platforms affected

Affects TypeScript enabled projects only

Motivation and Context

Type definitions to allow programmatic control of the splashscreen are needed in cordova-ios now that cordova-plugin-splashscreen was obsoleted as part of cordova-ios 6.X platform update.

Description

Import the current type definitions from cordova-plugin-splashscreen and expose them for use within a typescript project.

Testing

I've imported this into an existing TypeScript-based application that has cordova-plugin-splashscreen removed, and ensured that TypeScript compilation produces no warnings or errors

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

peitschie commented 2 years ago

Relates to https://github.com/apache/cordova-android/pull/1489

erisu commented 2 years ago

The code seems OK but I am unsure about the header license.

We always use the Apache-2.0 license header.

I know you are just copying the existing file contents from cordova-plugin-splashscreen, but I am even surprised that someone approved that.

Also, the URL in the header comment, https://github.com/apache/cordova-platform, does not exist.

I am not sure what should be done regarding the license but other then that, everything seems OK.

peitschie commented 2 years ago

@erisu I'll just replace this with the existing license from the javascript source files.

apache / cordova-ios