apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.16k stars 986 forks source link

fix: uninstall plugin with asset tag #1444

Closed jcesarmobile closed 4 months ago

jcesarmobile commented 4 months ago

The comment says // deletes file/directory without checking, but it can't delete directories without the { recursive: true, force: true }. I've created a new function for deleting directories as deleting files this way breaks the tests, so changed the two calls that removed folders to use the new function and kept the other that deleted a file with the old method call.

closes https://github.com/apache/cordova-ios/issues/1443

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.36%. Comparing base (b5f5cd2) to head (0da5f70).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1444 +/- ## ========================================== + Coverage 78.35% 78.36% +0.01% ========================================== Files 16 16 Lines 1825 1826 +1 ========================================== + Hits 1430 1431 +1 Misses 395 395 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.