apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.16k stars 986 forks source link

fix(emulators): Fix listing emulator targets #1495

Closed dpogue closed 1 month ago

dpogue commented 1 month ago

Platforms affected

iOS

Motivation and Context

I think I accidentally broke this during earlier refactoring for 8.0.0, but it was now trying to (and incorrectly) listing the simulator devices rather than the simulator device/runtime combinations.

Description

Restore the correct listing for simulator devices/runtimes when using cordova run ios --list

Testing

Tested running npx cordova run ios --list and ensured the output matched between these changes and 7.1.1

Checklist

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (92df3b7) to head (b34d866).

Files with missing lines Patch % Lines
lib/run.js 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1495 +/- ## ========================================== - Coverage 80.89% 80.86% -0.03% ========================================== Files 16 16 Lines 1842 1840 -2 ========================================== - Hits 1490 1488 -2 Misses 352 352 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.