Closed msmtamburro closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.86%. Comparing base (
2f0e19e
) to head (9ceadf4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Platforms affected
iOS
Motivation and Context
Addresses #1486
Description
Simply clears the _webViewEngine stored property in this class on ‘dispose’ so that it no longer retains a reference to the WKWebView after dispose.
Testing
In the platform centered approach (e.g, adding cordova-ios to an otherwise native app) via a swift package, we can subclass CDVViewController and dispose all plugins when our ViewController is no longer in the view hierarchy.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)