search

apache / cordova-plugin-wkwebview-engine

[DEPRECATED] Apache Cordova wkwebview engine plugin
Apache License 2.0
612 stars 358 forks source link

added WKWebViewOnly to Readme #161

Closed machinaeXphilip closed 4 years ago

machinaeXphilip commented 4 years ago

added WKWebViewOnly to Readme to config Readme explanation.

Motivation and Context

This is (afaik) needed in order to be able to upload new apps to the iOS App Store. I assume because without it both WebViews get delivered which then triggers Apples ITMS-90809: Deprecated API Usage Error on processing of the App

Testing

try upload app to AppStoreConnect via XCode without the added xml tag and without.

with the tag: ITMS-90809: Deprecated API Usage Error

with the tag: passes

machinaeXphilip commented 4 years ago

Thanks for your contribution!

I would actually add a note to this preference stating that WKWebViewOnly only works on cordova-ios versions >= 5.1.0

thank you! implemented the version limitation.

is there information to be referenced about the behaviour above 5.1.0 that could be included additionally?

breautek commented 4 years ago

you might also have to you might have to also

Think you might have doubled up some words here :)

is there information to be referenced about the behaviour above 5.1.0 that could be included additionally?

I don't believe so... this plugin is not usable on cordova-ios@6, but that's already documented from https://github.com/apache/cordova-plugin-wkwebview-engine/commit/486e5a74ec826b88d156dafe427aabf0827162ab

There isn't an official conclusion from Apache yet, but I'm pretty sure this plugin is going to become deprecated soon.

machinaeXphilip commented 4 years ago

awkward. sorry for the extra work.

this is what i get for multitasking.

breautek commented 4 years ago

If I don't receive a second review by Monday I'll just go ahead and merge since this is a trivial change.

machinaeXphilip commented 4 years ago

thanks! i commited those. indeed better wording!