search

apache / datafusion-python

Apache DataFusion Python Bindings
https://datafusion.apache.org/python
Apache License 2.0
321 stars 64 forks source link

Upgrade window UDF api #730

Closed Michael-J-Ward closed 3 days ago

Michael-J-Ward commented 2 weeks ago

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

datafusion is in process of removing their built-in window-functions, which our current window function relies on. sum has already been removed which brakes the q11_important_stock_identification.py tpch example.

Additional context

AggregateFunction::Sum enum variant is still defined, but can not be used.

I suspect that the proper solution is to register the new UDAFs with the function registry.

As a workaround for releasing 39, I explicitly match on name == "sum" and redirect to the UDAF.

UDAF Migration Epic: https://github.com/apache/datafusion/issues/8709

Michael-J-Ward commented 2 weeks ago

@timsaucer could you take a look at this once #728 is merged?

timsaucer commented 2 weeks ago

I’ll be happy to but on vacation so it will be a couple weeksOn Jun 14, 2024, at 1:49 PM, Michael J Ward @.***> wrote: @timsaucer could you take a look at this once #728 is merged?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>