[MINOR UPDATE] use StandardCharsets

apache / drill

Apache Drill is a distributed MPP query layer for self describing data

https://drill.apache.org/

Apache License 2.0

1.93k stars 984 forks source link

[MINOR UPDATE] use StandardCharsets #2870

Closed pjfanning closed 6 months ago

pjfanning commented 6 months ago

The aim is to use Java built-in StandardCharsets.

replace code calls where we use APIs that pass the charset as a string vale (not all APIs have alternatives that take Charset object inputs)
replace Guava Charsets with Java built-in StandardCharsets

cgivre commented 6 months ago

@jnturton Do we want to back port this PR?

jnturton commented 6 months ago

@jnturton Do we want to back port this PR?

One rule of thumb I apply to minor enhancements is "are the immediate beneficiaries Drill devs or users"? If they're Drill devs, and I'd vote that they are here, then the change can just as well remain only in master where dev gets done.