apache / echarts

Apache ECharts is a powerful, interactive charting and data visualization library for browser
https://echarts.apache.org
Apache License 2.0
60.26k stars 19.61k forks source link

[Bug] Redraw not triggered after setOption call inside custom toolbox feature #17437

Open Cody-Soultz opened 2 years ago

Cody-Soultz commented 2 years ago

Version

5.3.3

Link to Minimal Reproduction

https://jsfiddle.net/codysoultz/xahwg3j4/22/

Steps to Reproduce

Two X axis graph with 2-D data. In my example, the data is furnace temperature of a coil of metal where the temperature is the y value and the footage into the coil and the time are the x axis. Check out the jsfiddle for details.

When setOption is called inside of the toolbox handler it never is not redrawn with new options until there is an action that causes a redraw.

Current Behavior

When the custom toolbox item is pressed nothing visually happens. In the jsfiddle you can cause a redraw by zooming in or out with the mouse wheel then the setOption takes effect

Expected Behavior

When setOption is called inside of the toolbox handler it should send an action for redraw if requitred.

Environment

No Framework

Any additional comments?

My workaround is to cause a "changeDataView" action to fire inside of the toolbox handler after the setOption function has been called. To see this uncomment lines 77-80 in the js of my jsfiddle. The jsfiddle has both the version with the workaround and without the workaround.

extensionAPI.dispatchAction({
  type: 'changeDataView',
  newOption: {}
});
Cody-Soultz commented 2 years ago

It’s been 2 months, Should I close the ticket as I have found a workaround? I would create a pull request, but I am unfamiliar how the update events are triggered and propagated.

github-actions[bot] commented 2 days ago

This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue.

Cody-Soultz commented 2 days ago

This is still an issue and I would like to see someone look at it with experience of how the refresh works.