Closed PHILO-HE closed 3 weeks ago
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename commit message and pull request title in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
@zml1206, could you take a look? This is a follow-up for a comment in your merged pr.
Just found some other issue. Let's hold on.
This pr once intended to use one same symbols.map set for version-script in both static build and dynamic build. But it seems we cannot achieve this. For static build (with vcpkg), the below symbol patterns need to be put inside extern "C++"
block. But for dynamic build, they should be moved out from this block. Otherwise, symbol conflict issue will be reported when running gluten cpp tests. One possible root cause is the use of different linking tool or linking options.
local:
extern "C++" {
*fL*::*;
*google::*;
};
As currently dynamic build has no symbol conflict so far, let's simply exclude the use of symbols.map in this build path.
What changes were proposed in this pull request?
This is a follow-up pr for this comment.
If not hidden, the below error can be reported when running gluten CPP test.
velox_memory_num_shared_leaf_pools
is declared in Velox undergoogle
namespace. SeeDEFINE_int32
used by this velox code. Even thoughlocal: *;
is defined for version script, we have to explicitly make all symbols under*google::*
namespace hidden. The possible reason is that the specified global*facebook::velox::*
symbols cover those*google::*
symbols.How was this patch tested?
CI.