[GLUTEN-7856][CORE] Ensure correct enabling of GlutenCostEvaluator

apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.

https://gluten.apache.org/

Apache License 2.0

1.22k stars 439 forks source link

[GLUTEN-7856][CORE] Ensure correct enabling of GlutenCostEvaluator #7857

Closed weixiuli closed 2 weeks ago

weixiuli commented 3 weeks ago

What changes were proposed in this pull request?

The GlutenConfig is not initialized by sparkConf when calling setPredefinedConfigs. As a result, GlutenConfig.getConf.enableGluten and GlutenConfig.getConf.enableGlutenCostEvaluator in setPredefinedConfigs only retrieve their default values. To ensure correct configuration, we should retrieve these settings directly from sparkConf.

(Fixes: https://github.com/apache/incubator-gluten/issues/7856)

github-actions[bot] commented 3 weeks ago

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Other pull requests

github-actions[bot] commented 3 weeks ago