search

apache / incubator-heron

Apache Heron (Incubating) is a realtime, distributed, fault-tolerant stream processing engine from Twitter
https://heron.apache.org/
Apache License 2.0
3.64k stars 598 forks source link

Enable configuration of packing defaults #1084

Open ajorgensen opened 8 years ago

ajorgensen commented 8 years ago

Currently the default padding values for the packing algorithms are hard coded and may need to be customized further depending on the users use case.

https://github.com/twitter/heron/blob/master/heron/packing/src/java/com/twitter/heron/packing/roundrobin/RoundRobinPacking.java#L74-L78

avflor commented 8 years ago

@ajorgensen This is a good suggestion and this one of the configuration changes I'm currently making in the ffdpacking algorithm.

maosongfu commented 8 years ago

👍

kramasamy commented 8 years ago

@avflor - is this complete? if it is, please close this.

avflor commented 8 years ago

@kramasamy It is complete but just for the binpacking algo. I will adapt round robin as we discussed yesterday and then I'll close this.