apache / incubator-kie-issues

Apache License 2.0
12 stars 1 forks source link

FEEL autocomplete does not recognize imported models when using the classic DMN Editor #1340

Open danielzhe opened 3 months ago

danielzhe commented 3 months ago

When the user uses the new boxed expression editor and the classic DMN Editor with imported models, the imported model elements are not recognized by the autocomplete and are painted in red (as a error) by the syntax highlight.

https://github.com/apache/incubator-kie-issues/assets/7305741/5f07cca8-73df-4992-89c5-b834736241fd

To fix this issue:

We need to load external models here: https://github.com/apache/incubator-kie-tools/blob/187a6e5d929b0b0ea1529b113fd2195a2f246a12/packages/stunner-editors-dmn-loader/src/index.tsx#L193

As it is loaded here: https://github.com/apache/incubator-kie-tools/blob/187a6e5d929b0b0ea1529b113fd2195a2f246a12/packages/dmn-editor/src/boxedExpressions/BoxedExpressionScreen.tsx#L114

jomarko commented 3 months ago

The ticket title says is only classic, but the ticket description says both new and classic editors are affected.

tiagobento commented 3 months ago

@danielzhe Could you please check? Also would be good to follow up on the Zulip thread that originated this issue... https://kie.zulipchat.com/#narrow/stream/232677-drools/topic/Syntax.20highlighting.20misleading.20for.20imported.20decisions.2E

danielzhe commented 3 months ago

The ticket title says is only classic, but the ticket description says both new and classic editors are affected.

Where?

jomarko commented 3 months ago

@danielzhe I mean this Screenshot 2024-06-27 140313

danielzhe commented 3 months ago

That's correct, @jomarko One thing is the DMN Editor, another thing is the boxed expression editor. There are two versions of both. The classic DMN Editor, the classic Boxed Expression Editor, the new DMN Editor, and the new Boxed Expression Editor.

The classic BEE does not have FEEL autocomplete, only the new one. So the issue happens when the user is using the classic DMN Editor and the new BEE.

I think the classic BEE is not available in all distributions, that's why the confusion.