apache / incubator-kie-kogito-images

Images for Kogito
http://kogito.kie.org
Apache License 2.0
23 stars 80 forks source link

NO-ISSUE - Fix Service Discovery BDD Test Scenario for SonataFlow devmode and builder. #1718

Closed ricardozanini closed 11 months ago

ricardozanini commented 11 months ago

Many thanks for submitting your Pull Request :heart:!

In this PR, we do a small fix in the feature test to verify if the service discovery add-on is installed. In the previous version, when we used Fabric8 the logs were printing a message failing to find the given service. Now that we are defaulting to the operator svc discovery, we don't have this message in the logs anymore, hence the error.

Relates to #1713

CI reported the error here: https://ci-builds.apache.org/blue/organizations/jenkins/KIE%2Fkogito%2Fmain%2Fnightly%2Fkogito-images.build-image/detail/kogito-images.build-image/172/pipeline/

Please make sure your PR meets the following requirements:

How to retest this PR or trigger a specific build: - (Re)run Jenkins tests Please add comment: Jenkins [test|retest] this - Prod tests Please add comment: Jenkins (re)run [prod|Prod|PROD]
How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
ricardozanini commented 11 months ago

@jstastny-cz can you shed light on this CI error?

Index 1 out of bounds for length 1

jstastny-cz commented 11 months ago

I officially hate the github branch source plugin, see:

For PR coming from my fork: CHANGE_FORK=jstastny-cz/kogito-images

For PR coming from your fork: CHANGE_FORK=ricardozanini

just because in your case the repository name equals.

That's wonderful for stability :/

@rodrigonull @cimbalek if you ever see this in future ;-) I'll add some ifs in the util scripts now.

jstastny-cz commented 11 months ago

We need

merged before retriggering.

Also I think this would prevent PR checks from working correctly:

And fix for that one would re-generate the pipelines.

kie-ci3 commented 11 months ago

PR job #7 was: FAILURE Possible explanation: Pipeline failure or project build failure

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/7/display/redirect See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-trusty-ui
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-management-console
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-task-console
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] unstable
WARNING: Tests on kogito-s2i-builder seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/7/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh