apache / incubator-uniffle

Uniffle is a high performance, general purpose Remote Shuffle Service.
https://uniffle.apache.org/
Apache License 2.0
388 stars 149 forks source link

[MINOR] improvement(server): Record more grpc process time and total metrics #2167

Closed maobaolong closed 1 month ago

maobaolong commented 1 month ago

What changes were proposed in this pull request?

Record more grpc process time and total metrics

Why are the changes needed?

Especially, the reportShuffleResult and getShuffleResultForMultiPart would be the most cost time call, this PR could measure the performance of these methods.

Does this PR introduce any user-facing change?

Introduced new metrics.

How was this patch tested?

Locally.

image image image
github-actions[bot] commented 1 month ago

Test Results

 2 926 files  ±0   2 926 suites  ±0   5h 56m 48s :stopwatch: + 1m 2s  1 041 tests ±0   1 039 :white_check_mark: ±0   2 :zzz: ±0  0 :x: ±0  13 003 runs  ±0  12 973 :white_check_mark: ±0  30 :zzz: ±0  0 :x: ±0 

Results for commit 8e8a3634. ± Comparison against base commit be23f613.

:recycle: This comment has been updated with latest results.

maobaolong commented 1 month ago

@jerqi Thanks for your review, PTAL

maobaolong commented 1 month ago

@jerqi Thanks for your review!