GH-2795: Fix race condition in datatype registration

Ostrzyciel commented 1 month ago

GitHub issue resolved #2795

Pull request Description:

Fixed a race condition in user-defined datatype registration. This change only touches the user-friendly getSafeTypeByName and does not change anything from the user's perspective (other than fixing the race condition). The registerDatatype method is left as-is, to allow for overriding datatype registrations if someone really wants to.

I've added some notes to registerDatatype and unregisterDatatype that it they have good "shoot-yourself-in-the-foot-with-a-bazooka" potential.

[ ] Tests are included – not sure how to test it... do we need tests here?
[x] Documentation change and updates are provided for the Apache Jena website
[x] Commits have been squashed to remove intermediate development commit messages.
[x] Key commit messages start with the issue number (GH-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.

See the Apache Jena "Contributing" guide.

arne-bdt commented 1 month ago

I don´t think, this is the way to solve the issue. --> discussion in https://github.com/apache/jena/issues/2795#issuecomment-2439653100

Ostrzyciel commented 1 month ago

Updated the PR with a different approach as per the discussion in the issue #2795

apache / jena

GH-2795: Fix race condition in datatype registration #2796