Replace mutexes with tbb concurrent containers if proper

apache / kvrocks

Apache Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine and is compatible with Redis protocol.

https://kvrocks.apache.org/

Apache License 2.0

3.48k stars 455 forks source link

Replace mutexes with tbb concurrent containers if proper #1389

Open PragmaTwice opened 1 year ago

PragmaTwice commented 1 year ago

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation

With TBB, now we can eliminate some mutexes applied on containers in our codebase with concurrent containers directly.

Solution

No response

Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

wanghenshui commented 1 year ago

tbb or folly::concurrentHashMap ?

PragmaTwice commented 1 year ago

tbb or folly::concurrentHashMap ?

We currently do not introduce folly as our dependency, since it is a far more large library.

infdahai commented 1 year ago

hey @PragmaTwice I want to try and investigate the tbb containter.

PragmaTwice commented 1 year ago

hey @PragmaTwice I want to try and investigate the tbb containter.

Assigned. Good luck.

LindaSummer commented 2 months ago

Hi @PragmaTwice ,

This issue seems to be stale for one year. Could this issue be assigned to me if it still needs to be resolved? I want to research the tbb container and make some contribution.

Best Regards, Edward