[Improvement] Support SSL for REST frontend service

apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.

https://kyuubi.apache.org/

Apache License 2.0

2.08k stars 906 forks source link

[Improvement] Support SSL for REST frontend service #4603

Open turboFei opened 1 year ago

turboFei commented 1 year ago

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?

support ssl for REST frontend service

How should we improve?

add ssl factory when building jetty server

Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
[ ] No. I cannot submit a PR at this time.

turboFei commented 1 year ago

@davidyuan1223 would you like to take this one? it is also related with restful.

davidyuan1223 commented 1 year ago

@davidyuan1223 would you like to take this one? it is also related with restful.

I can try

turboFei commented 1 year ago

thanks @davidyuan1223

davidyuan1223 commented 1 year ago

thanks @davidyuan1223

hello I want ask a question, should I test the rest ssl connection? I have fix the code

turboFei commented 1 year ago

thanks @davidyuan1223

hello I want ask a question, should I test the rest ssl connection? I have fix the code

could you raise the pr first?

If it is difficult to add an UT for that, you can add some screenshot for that.

davidyuan1223 commented 1 year ago

thanks @davidyuan1223

hello I want ask a question, should I test the rest ssl connection? I have fix the code

could you raise the pr first?

If it is difficult to add an UT for that, you can add some screenshot for that.

sorry , this is my first code fix issue, I will add some code to test in ut, if success I will raise the pr