apache / mahout

Mirror of Apache Mahout
Apache License 2.0
2.14k stars 945 forks source link

MAHOUT-468 & MAHOUT-469 Add parameter object and bind at execution #472

Closed rawkintrevo closed 2 weeks ago

rawkintrevo commented 3 weeks ago

Purpose of PR:

Please give a short description of what this PR is for.

468 Add a parameter object

469 Bind Parameters at execution

with bonus notebook for optimization loop external to qumat

Important ToDos

Please mark each with an "x"

https://colab.research.google.com/drive/1QgeqKZtkC_hOmffRprxJWMcC1g9YsMOE?usp=sharing qiskit https://colab.research.google.com/drive/1M5tT7h2wRiGNYx48g_FDGPTKuogKxEzc?usp=sharing cirq

bracket untested

Does this change break earlier versions? no

Is this the beginning of a larger project for which a feature branch should be made? no

rawkintrevo commented 3 weeks ago

On the last commit- i had to specify my fork in the install (bc I added functionality that isn't available in main), we need a more elegant solution to do this.

andrewmusselman commented 2 weeks ago

Added these two issues to track minor improvements https://github.com/apache/mahout/issues/474 https://github.com/apache/mahout/issues/475