Keep manual sorting of open files when reopening project

dev-fan commented 2 years ago

Apache NetBeans version

Apache NetBeans 14

What happened

In the settings, Appearance > Document Tabs > Sort nothing. I work in a project and arrange files in the tabs panel as I see fit. If I close the netbins program, they will open in the same order that I sorted them manually. But if I close the project in the program and then reopen it, then the manual arrangement of the files changes to a messy one.

This happens both in the latest version and in the previous ones (13, 12.x and earlier), it also happens in Windows and Ubuntu

How to reproduce

Open project. Open its files (10 pieces) and set their order yourself as convenient. Close the project (not Netbeans), open the project again. The order of files in tabs is changed.

Did this work correctly in an earlier version?

No / Don't know

Operating System

Windows 7 10, Ubuntu 18.04-21.10

JDK

16 and earler

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

No response

Are you willing to submit a pull request?

No

Code of Conduct

Yes

pinta83 commented 1 year ago

Bumb.... Any progress on this?

dev-fan commented 1 year ago

No, and I don't think they ever will.

dev-fan commented 5 months ago

@neilcsmith-net Hi. I installed version 22 (jdk22), but the problem remained. Are they going to fix this or not? In theory it shouldn't be too difficult to fix this problem.

neilcsmith-net commented 5 months ago

@dev-fan who is "they"?! This issue has contribution welcome on it, and as you said it shouldn't be too difficult ... :wink:

dev-fan commented 5 months ago

@neilcsmith-net If you wrote in PHP, I would definitely help. I don't know JAVA. They are, in a sense, developers. I understand that this is an open project, but I don’t know how you distribute tasks.

neilcsmith-net commented 5 months ago

@dev-fan we don't "distribute tasks" as such. People work on what they want to work on. As far as I know, no-one has expressed interest on working on this feature, so I put contribution welcome on it.

@mbien and I were discussing some improvements to project groups and document groups recently. That could perhaps encompass this feature? Or the project configuration could be enhanced to store this better?

dev-fan commented 5 months ago

Unfortunately, I don't know Java and can't help. But as I remember the list of open files is stored in an XML file, I thought that there was simply no need to sort this file when closing or opening a project, but store it in the order in which the tabs were opened. Thanks for your answers, I'll wait for someone to fix it.

neilcsmith-net commented 5 months ago

They are stored slightly differently per project type. Having consistent order in the storage would be good - I think that might be doable using LinkedHashSet rather than HashSet in a few places in https://github.com/apache/netbeans/blob/master/ide/projectui/src/org/netbeans/modules/project/ui/ProjectUtilities.java

But then you have to also ensure files get opened in order, and the implications of that, and also consider whether or how to handle document tab groups. I personally find the inconsistent order less frustrating in practice than losing the tab groups.

mbien commented 5 months ago

https://github.com/apache/netbeans/issues/7085 is related.

apache / netbeans