Closed style95 closed 1 year ago
Merging #5435 (731eb8b) into master (951ce58) will increase coverage by
18.08%
. The diff coverage is50.00%
.:exclamation: Current head 731eb8b differs from pull request most recent head a066119. Consider uploading reports for the commit a066119 to get more accurate results
@@ Coverage Diff @@
## master #5435 +/- ##
===========================================
+ Coverage 58.52% 76.60% +18.08%
===========================================
Files 241 241
Lines 14632 14634 +2
Branches 616 607 -9
===========================================
+ Hits 8563 11211 +2648
+ Misses 6069 3423 -2646
Files Changed | Coverage Δ | |
---|---|---|
...la/org/apache/openwhisk/core/invoker/Invoker.scala | 71.60% <50.00%> (+1.98%) |
:arrow_up: |
... and 135 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Without this change, invokers with the ID assignor can not be deployed.
LGTM 👍
Description
As
ZOOKEEPER_HOSTS
is removed from the required properties, it is no longer transformed into the whisk config from the environment variables. But when the instance id assigned is used, the zookeeper host becomes a required property. This change is to make it an optional property.Related issue and scope
My changes affect the following components
Types of changes
Checklist: