Upgrade the docker version to 23.0.6

apache / openwhisk

Apache OpenWhisk is an open source serverless cloud platform

https://openwhisk.apache.org/

Apache License 2.0

6.56k stars 1.17k forks source link

Upgrade the docker version to 23.0.6 #5436

Closed style95 closed 8 months ago

style95 commented 1 year ago

Description

The docker version of the GitHub action runner is 23.0.6. Instead of downgrading the engine version I want to give a shot to upgrade the client version.

Related issue and scope

[x] I opened an issue to propose and discuss this change (#5433)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Scheduler
[x] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

codecov-commenter commented 1 year ago

Codecov Report

Merging #5436 (5ffbafa) into master (951ce58) will increase coverage by 18.21%. The diff coverage is 100.00%.

:exclamation: Current head 5ffbafa differs from pull request most recent head ed67fc9. Consider uploading reports for the commit ed67fc9 to get more accurate results

@@             Coverage Diff             @@
##           master    #5436       +/-   ##
===========================================
+ Coverage   58.52%   76.73%   +18.21%     
===========================================
  Files         241      241               
  Lines       14632    14632               
  Branches      616      616               
===========================================
+ Hits         8563    11228     +2665     
+ Misses       6069     3404     -2665

Files Changed	Coverage Δ
...sk/core/containerpool/docker/DockerContainer.scala	`98.79% <ø> (+4.81%)`	:arrow_up:
...enwhisk/core/containerpool/docker/RuncClient.scala	`100.00% <100.00%> (+16.66%)`	:arrow_up:

... and 134 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

style95 commented 1 year ago

Since upgrading the docker version could impact many downstream, I think it would be better to separate the change to upgrade docker and the change to maximize the build space for multi-runtime tests.

style95 commented 1 year ago

Once this PR is merged, I would rebase this PR.

style95 commented 1 year ago

It turns out that this change is not directly related to the failure of multi-runtime tests. So it's not that urgent now but it is still worth discussing.

bdoyle0182 commented 1 year ago

LGTM this is very long overdue, are there any blockers to merging this. I believe this should only affect docker client right anyways?

style95 commented 1 year ago

I have been thinking of running a performance test with this version. And last time we upgraded the docker version, some downstream like IBM needed some time to prepare for taking the change in. I thought that a similar thing might happen.

style95 commented 1 year ago

This PR has opened for a while, I would merge this.