search

apache / paimon-rust

Apache Paimon Rust The rust implementation of Apache Paimon.
https://paimon.apache.org/
Apache License 2.0
105 stars 32 forks source link

feat(spec): implement data field #21

Closed devillove084 closed 3 months ago

devillove084 commented 4 months ago

This PR will implement DataField. close #22

Xuanwo commented 4 months ago

Thanks a lot! We're planning to refactor the data type first, so this PR may need to wait a bit until we figure out the correct approach. Sorry for any inconvenience.

devillove084 commented 3 months ago

I noticed that the new data type has been merged, so I rebased onto the latest main branch and ensured that all local tests and clippy checks passed. When you have time, could you please approve the changes and review the code? If there are any omissions or inaccuracies, please point them out, and I'll address them promptly. @Xuanwo

Xuanwo commented 3 months ago

Hi, this PR includes some unrelated changes that make it difficult to review. Could you please address this?

JingsongLi commented 3 months ago

Test failed, @devillove084 can you fix the test?

devillove084 commented 3 months ago

Test failed, @devillove084 can you fix the test?

Okay, I will repair it later

devillove084 commented 3 months ago

I've already checked and fixed the issues with the tests. Whenever you have time, could you please help approve it? Thank you very much! @JingsongLi