search

apache / paimon-rust

Apache Paimon Rust The rust implementation of Apache Paimon.
https://paimon.apache.org/
Apache License 2.0
105 stars 32 forks source link

ut: add test for `Snapshot` #39

Closed QuakeWang closed 3 months ago

QuakeWang commented 3 months ago

part of #26

QuakeWang commented 3 months ago

GitHub action doesn't seem to run automatically 🥲. @Xuanwo

Xuanwo commented 3 months ago

GitHub action doesn't seem to run automatically 🥲. @Xuanwo

Thanks for the feedback. I will check with the INFRA team.

Xuanwo commented 3 months ago

Hi, it should be work now. Please try push a new commit or a new PR, thanks!

QuakeWang commented 3 months ago

Hi, it should be work now. Please try push a new commit or a new PR, thanks!

It works!

QuakeWang commented 3 months ago

Thank you for this PR. However, I would prefer to see a test that can serialize/deserialize actual snapshot files. The current PR only tests simple get/set operations, which are already covered by TypedBuilder.

Hi, I have add serde_json for the serialize/deserialize test, PTAL 👀