search

apache / pulsar-helm-chart

Official Apache Pulsar Helm Chart
https://pulsar.apache.org/
Apache License 2.0
212 stars 224 forks source link

fix: broker extraEnv variable #540

Closed lenglet-k closed 1 month ago

lenglet-k commented 1 month ago

Fixes #539

Motivation

fix env object declared twice ni broker.yaml

QUESTION: It's possible to rename extreEnvs to extraEnvs ?

Modifications

Use only one env object in broker

Verifying this change

lhotari commented 1 month ago

QUESTION: It's possible to rename extreEnvs to extraEnvs ?

Makes sense to fix the typo.

lenglet-k commented 1 month ago

QUESTION: It's possible to rename extreEnvs to extraEnvs ?

Makes sense to fix the typo.

it can cause breaking change if I rename, can I avoid breaking change by keeping the old value in the if ( or .values.broker.extraEnvs .value.broker.extreEnvs )? @lhotari

lhotari commented 1 month ago

QUESTION: It's possible to rename extreEnvs to extraEnvs ?

Makes sense to fix the typo.

it can cause breaking change if I rename, can I avoid breaking change by keeping the old value in the if ( or .values.broker.extraEnvs .value.broker.extreEnvs )? @lhotari

It's fine. I'll add a note to the next release notes about the change. I'll be bumping the version to 3.7.0 with the next release to indicate that there could be minor breaking changes.

lenglet-k commented 1 month ago

QUESTION: It's possible to rename extreEnvs to extraEnvs ?

Makes sense to fix the typo.

it can cause breaking change if I rename, can I avoid breaking change by keeping the old value in the if ( or .values.broker.extraEnvs .value.broker.extreEnvs )? @lhotari

It's fine. I'll add a note to the next release notes about the change. I'll be bumping the version to 3.7.0 with the next release to indicate that there could be minor breaking changes.

Ok so, i rename only to extraEnvs. And an other question, what's the cycle of release (because we wait 3.6.0 ^^' )?

lhotari commented 1 month ago

Ok so, i rename only to extraEnvs. And an other question, what's the cycle of release (because we wait 3.6.0 ^^' )?

3.6.0 was released in the last hour: https://lists.apache.org/thread/2xg6czzp6xqr829xjvzzx1tvfwzjov6c 3.7.0 will be released after Pulsar 4.0.0 which is currently in voting phase. ETA for 3.7.0 with Pulsar 4.0.0 by default is Oct 28th. btw. Please test Pulsar 4.0.0-candidate-1 to find any possible critical regressions.

lenglet-k commented 1 month ago

Toda

Ok so, i rename only to extraEnvs. And an other question, what's the cycle of release (because we wait 3.6.0 ^^' )?

3.6.0 was released in the last hour: https://lists.apache.org/thread/2xg6czzp6xqr829xjvzzx1tvfwzjov6c 3.7.0 will be released after Pulsar 4.0.0 which is currently in voting phase. ETA for 3.7.0 with Pulsar 4.0.0 by default is Oct 28th. btw. Please test Pulsar 4.0.0-candidate-1 to find any possible critical regressions.

we use argocd to deploy the charts and it doesn't seem to find your candidate versions. I need to check this problem more carefully

lhotari commented 1 month ago

we use argocd to deploy the charts and it doesn't seem to find your candidate versions. I need to check this problem more carefully

Docker images for 4.0.0-candidate-1 (https://lists.apache.org/thread/jqnvrh45tly9yzyvgcq33v7tsqv12ng3): docker pull lhotari/pulsar:4.0.0-92448d5 https://hub.docker.com/layers/lhotari/pulsar/4.0.0-92448d5/images/sha256-285b28c50308f2a452a58b6a57529fbcf41517f46c2cae2cd9482659f9491a97?context=explore docker pull lhotari/pulsar-all:4.0.0-92448d5 https://hub.docker.com/layers/lhotari/pulsar-all/4.0.0-92448d5/images/sha256-4111ea92fde9b74f18165c42ebe9039447d01847bec9c71796a31776cdbea9f8?context=explore

Testing in #530 at the moment.

lhotari commented 1 month ago

we use argocd to deploy the charts and it doesn't seem to find your candidate versions. I need to check this problem more carefully

in some cases, it might be necessary to prefix the docker image name with docker.io/ for example docker.io/lhotari/pulsar:4.0.0-92448d5 / docker.io/lhotari/pulsar-all:4.0.0-92448d5.