apache / pulsar

Apache Pulsar - distributed pub-sub messaging system
https://pulsar.apache.org/
Apache License 2.0
14.27k stars 3.59k forks source link

pulsar bookkeeper.conf cannot cover all bookkeeper config property keys #16895

Open yapxue opened 2 years ago

yapxue commented 2 years ago

Is your enhancement request related to a problem? Please describe. bookkeeper.conf in https://github.com/apache/pulsar cannot cover all keys in bk_server.conf in https://github.com/apache/bookkeeper . Starting a bookkeeper in pular archive cannot customize some bookkeeper configations by add configmap key values. For example serverNumIOThreads.

Describe the solution you'd like copy all property keys in bk_server.conf to bookkeeper.conf

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

MarvinCai commented 2 years ago

there's a script just for this purpose: https://github.com/apache/pulsar/blob/master/docker/pulsar/scripts/apply-config-from-env.py You can supply any custom config via env then run this script like apply-config-from-env.py bookkeeper.conf To supply config key that's not already in bookkeeper.conf, add prefix PULSAR_PREFIX_ to it so it can be properly recognized by the script.

yapxue commented 2 years ago

there's a script just for this purpose: https://github.com/apache/pulsar/blob/master/docker/pulsar/scripts/apply-config-from-env.py You can supply any custom config via env then run this script like apply-config-from-env.py bookkeeper.conf To supply config key that's not already in bookkeeper.conf, add prefix PULSAR_PREFIX_ to it so it can be properly recognized by the script.

But some bookkeeper config like serverNumIOThreads is not in https://github.com/apache/pulsar/blob/master/conf/bookkeeper.conf and not in "keys" in the python script https://github.com/apache/pulsar/blob/master/docker/pulsar/scripts/apply-config-from-env.py#L72 and it cannot be applied.

github-actions[bot] commented 2 years ago

The issue had no activity for 30 days, mark with Stale label.