apache / pulsar

Apache Pulsar - distributed pub-sub messaging system
https://pulsar.apache.org/
Apache License 2.0
14.11k stars 3.56k forks source link

[Bug] Checkstyle check is not applied to all tests #23079

Open BewareMyPower opened 1 month ago

BewareMyPower commented 1 month ago

Search before asking

Read release policy

Version

master branch

Minimal reproduce step

Add a test pulsar-broker/src/test/java/org/apache/pulsar/SimpleTest.java

package org.apache.pulsar;

// 1. The import order is wrong
import org.testng.annotations.Test;
import org.testng.Assert;

public class SimpleTest {
    @Test // 2. The indents and number blanks are wrong
    public void test() {Assert.assertEquals(1 + 2, 3);}
}

Run

mvn initialize checkstyle:check -pl pulsar-broker

What did you expect to see?

The checkstyle:check should fail.

What did you see instead?

It succeeded.

Anything else?

No response

Are you willing to submit a PR?

four1er commented 1 month ago

I want to solve it, pls assign it to me, thx!