search

apache / rocketmq

Apache RocketMQ is a cloud native messaging and streaming platform, making it simple to build event-driven applications.
https://rocketmq.apache.org/
Apache License 2.0
21.3k stars 11.71k forks source link

[ISSUE #8974] Support recalling of delay message #8975

Open imzs opened 1 week ago

imzs commented 1 week ago

[ISSUE #8974] Support recalling of delay message

qianye1001 commented 1 week ago

Returning an additional handle in all send Response operations introduces overhead. If this feature is not required, there should be an option to disable it.

imzs commented 1 week ago

Returning an additional handle in all send Response operations introduces overhead. If this feature is not required, there should be an option to disable it.

This field is somewhat similar to transactionId. As previously mentioned, the API defines a common semantic. In cases where unsupported message types are encountered, it returns null values, which also implies that the current message does not support recall operation, this may be considered as a switch.

RongtongJin commented 3 days ago

It seems that the newly added integration test are failing. image

imzs commented 1 day ago

It seems that the newly added integration test are failing. image

The tests passed locally, it maybe timeout issue; I'll try to fix it.

codecov-commenter commented 1 day ago

Codecov Report

Attention: Patch coverage is 65.77540% with 128 lines in your changes missing coverage. Please review.

Project coverage is 48.06%. Comparing base (715dd5a) to head (b50755f). Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...ient/trace/hook/DefaultRecallMessageTraceHook.java 12.90% 27 Missing :warning:
...apache/rocketmq/client/trace/TraceDataEncoder.java 0.00% 22 Missing :warning:
...ng/protocol/header/RecallMessageRequestHeader.java 0.00% 16 Missing :warning:
...cketmq/proxy/grpc/v2/GrpcMessagingApplication.java 0.00% 11 Missing :warning:
...ketmq/broker/processor/RecallMessageProcessor.java 89.36% 8 Missing and 2 partials :warning:
.../java/org/apache/rocketmq/common/BrokerConfig.java 28.57% 5 Missing :warning:
...g/protocol/header/RecallMessageResponseHeader.java 0.00% 5 Missing :warning:
...ing/protocol/header/SendMessageResponseHeader.java 28.57% 4 Missing and 1 partial :warning:
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 81.25% 3 Missing :warning:
...tmq/proxy/service/message/LocalMessageService.java 82.35% 3 Missing :warning:
... and 15 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #8975 +/- ## ============================================= + Coverage 47.66% 48.06% +0.39% - Complexity 11766 12125 +359 ============================================= Files 1304 1311 +7 Lines 91174 93606 +2432 Branches 11711 12271 +560 ============================================= + Hits 43456 44988 +1532 - Misses 42346 43167 +821 - Partials 5372 5451 +79 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.