apache / rocketmq

Apache RocketMQ is a cloud native messaging and streaming platform, making it simple to build event-driven applications.
https://rocketmq.apache.org/
Apache License 2.0
21.3k stars 11.71k forks source link

[ISSUE #8460] Set default broker name when revive found ack without broker name field #8981

Closed lizhimins closed 4 days ago

lizhimins commented 4 days ago

Set default broker name when revive found ack without broker name field

POP CK 新旧格式兼容,为了尽可能的减少消费重复,当没有 brokerName 在 ack 信息里的时候自动补全

Which Issue(s) This PR Fixes

Fixes #8460

Brief Description

How Did You Test This Change?

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.64%. Comparing base (a8779c0) to head (c788856).

Files with missing lines Patch % Lines
...he/rocketmq/broker/processor/PopReviveService.java 33.33% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #8981 +/- ## ============================================= - Coverage 47.70% 47.64% -0.07% + Complexity 11782 11761 -21 ============================================= Files 1304 1304 Lines 91188 91192 +4 Branches 11713 11715 +2 ============================================= - Hits 43502 43446 -56 - Misses 42315 42366 +51 - Partials 5371 5380 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: