fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically

apache / rocketmq

Apache RocketMQ is a cloud native messaging and streaming platform, making it simple to build event-driven applications.

https://rocketmq.apache.org/

Apache License 2.0

21.3k stars 11.71k forks source link

fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically #8983

Open AuroraTwinkle opened 4 days ago

AuroraTwinkle commented 4 days ago

Which Issue(s) This PR Fixes

The https://github.com/apache/rocketmq/pull/6426 has fixed topicConfig update atomic problem, but the SubscriptionGroupConfig and MessageRequestMode has not been fixed. So I submit a PR to fix them!

Brief Description

How Did You Test This Change?

AuroraTwinkle commented 1 day ago

It would be great if you can add a unit test to verfiy this change.

Ok, I'll add the unit test as soon as possible. Thanks!

AuroraTwinkle commented 1 day ago

It would be great if you can add a unit test to verfiy this change.

I have added a unit test for it, looking forward to your review.