apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
63.06k stars 13.96k forks source link

fix(embedded): Hide anchor links in embedded mode #31194

Closed Vitor-Avila closed 2 days ago

Vitor-Avila commented 2 days ago

SUMMARY

The Tab and Header UI elements in the dashboard have an AnchorLink. These are currently visible in embedded mode. Embedded users are external that don't have access to the instance directly, so these links should not be visible.

This PR hides AnchorLinks in embedded mode.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before image

After image

TESTING INSTRUCTIONS

Tests added. For manual testing:

  1. Create a dashboard containing at least a header and a tab.
  2. Load this dashboard in embedded mode.
  3. Validate the AnchorLinks are not visible.

ADDITIONAL INFORMATION