search

apal21 / nextjs-progressbar

A simple Next.js progressbar component using NProgress.
https://www.npmjs.com/package/nextjs-progressbar
MIT License
788 stars 64 forks source link

Invalid aria roles used #102

Open ApinisMikelis opened 1 year ago

ApinisMikelis commented 1 year ago

This dependency introduces accessibility issues: https://github.com/rstacruz/nprogress

It is using invalid aria roles. The repo has a lot of issues about this and even pull-requests, but it seems like the package is just abandoned.

Here is the issue: https://github.com/rstacruz/nprogress/issues/232

In the issue there is a forked version mentioned where this is resolved (and the repo is not abandoned): https://github.com/nmackey/accessible-nprogress

I suggest switching these dependencies..

mirko-kienle commented 1 year ago

We've run into this issue as well with automated a11y tests. Second the suggestion to switch dependencies to the forked version.