apertium / lttoolbox

Finite state compiler, processor and helper tools used by apertium
http://wiki.apertium.org/wiki/Lttoolbox
GNU General Public License v2.0
18 stars 22 forks source link

ICU stuff #115

Closed mr-martian closed 3 years ago

mr-martian commented 3 years ago

ICU changes (closes #81)

efficiency, readability, and code style changes

helper function and dependency changes

mr-martian commented 3 years ago

Do we actually need that whole m4 script? Can we just ask pkg-config about icu-io directly?

TinoDidriksen commented 3 years ago

Do we actually need that whole m4 script? Can we just ask pkg-config about icu-io directly?

Agreed. Just do it like https://github.com/apertium/lexd/blob/master/configure.ac#L19-L20

And I see /home/daniel/lttoolbox/lttoolbox/nft.nrm in that diff.

TinoDidriksen commented 3 years ago

Also, I don't think a normalization tool belongs in lttoolbox - that's something we probably want to adjust separately, so a repo of its own would be nice.

TinoDidriksen commented 3 years ago

So far it looks like UnicodeString is suitable, but it will be interesting to see benchmarks. In CG-3 I use typedef std::basic_string<UChar> UString; for most strings, because it has a nicer interface and is movable.

TinoDidriksen commented 3 years ago

LGTM