This parameter list seems to be growing quite long - is it better to encapsulate in an object and pass it? Basically a collection of parameters that Aperture JSON supports and set the ones that are relevant?

aperture-data / aperturedb-python

ApertureDB Python Client

Other

7 stars 3 forks source link

This parameter list seems to be growing quite long - is it better to encapsulate in an object and pass it? Basically a collection of parameters that Aperture JSON supports and set the ones that are relevant? #490

Closed gsaluja9 closed 3 days ago

gsaluja9 commented 2 months ago

          This parameter list seems to be growing quite long - is it better to encapsulate in an object and pass it? Basically a collection of parameters that Aperture JSON supports and set the ones that are relevant?

_Originally posted by @vishakha041 in https://github.com/aperture-data/aperturedb-python/pull/489#discussion_r1775662470_

gsaluja9 commented 2 months ago

This should be made into a dataclass, and see if some logic from spec and helper functions could be a method of the class.

gsaluja9 commented 2 months ago

Another thing to consider:

instead of generate_add_query, an object.save() to actually save.

gsaluja9 commented 3 days ago

started a discussion for this. #529