search

apexad / homebridge-eufy-robovac

Homebridge plugin for Eufy RoboVac
MIT License
51 stars 18 forks source link

update dependencies #11

Closed apexad closed 4 years ago

apexad commented 4 years ago

Just npm audit fix to update dependencies.

joshstrange commented 4 years ago

@apexad I'm assuming that after I merge this I should bump to the next eufy-robovac version that I just released?

apexad commented 4 years ago

@joshstrange yes, please bump versions of this plugin (which I think will actually be 1.0.4) and eufy-robovac too. I can also do it once we make me a collaborator. Up to you.

joshstrange commented 4 years ago

@apexad This has been merged, I bumped the eufy-robovac the newest, and published this under 1.1.0. I'm working on adding you now

apexad commented 4 years ago

@joshstrange I just wanted to check with you to confirm if it is ok to add myself as an author of this plugin and node script in package.json? I'm planning on doing a bunch of updates and just want some credit there for it, and it will help to redirect questions to me on Reddit/Github/Discord.

apexad commented 4 years ago

@MonsterEnergy-wtf I apologize for accidentally deleting your comment. Also, I greatly appreciate that you let us all know this plugin was still working.

However, there was already a built dist/index.js floating around. It actually seems like the real issue was simply that when this project was last updated prior to my coming onto it that the /dist/ folder was not getting pushed to npm.

I've already made changes in the published v1.1.1 to correct this and already have a beta version on npm https://www.npmjs.com/package/homebridge-eufy-robovac (which I am sure @joshstrange was notified of) that I am testing with other changes (removing webpack and just using tsc (type script compiler) and also removing the IP address as a config option). Since this all looks good, as far as I can tell, I will actually be working on making the 'Find' button optional and adding a config.schema.json (for https://www.npmjs.com/package/homebridge-config-ui-x) before publishing an updated version very soon. If @joshstrange responds prior to then, I will also make the author update which I believe will be well deserved.

So, with that in mind, I think it's fair to say I've already spent.a considerable amount of time on this project as well as it's underlying library https://github.com/joshstrange/eufy-robovac where similar changes have been made including a pushed beta.

apexad commented 4 years ago

@joshstrange @MonsterEnergy-wtf FYI, I pushed v1.2.0 of the plugin and 1.4.0 of the underlying eufy-robovac library. As I mentioned above, it does the following: