fix: inconsistencies between dark and light theme override

api-platform / admin

A beautiful and fully-featured administration interface builder for hypermedia APIs

https://api-platform.com/docs/admin/

MIT License

480 stars 130 forks source link

fix: inconsistencies between dark and light theme override #487

Closed fsidobre closed 1 year ago

fsidobre commented 1 year ago

Q	A
Branch?	main
Tickets	#486
License	MIT

While overriding the react-admin theme, changes already made by react-admin to the mui theme for the components were imported for the dark mode but not for the light mode.

This PR re-adds those changes to the light mode.

fsidobre commented 1 year ago

I was actually checking why those values in tests were expected to be null and completely forgot about this change (that I saw earlier today 😫) in react-admin, thank you for checking on your side.

alanpoulain commented 1 year ago

No problem, it's hard to track all the changes which may impact this lib :sweat_smile:

alanpoulain commented 1 year ago

Thanks @fsidobre.