search

api7 / apisix-build-tools

Build tools to package and release
Apache License 2.0
123 stars 95 forks source link

Support building openresty via openssl which maintained by openresty itself #171

Open soulbird opened 2 years ago

soulbird commented 2 years ago

When we compile openresty, we need to use openssl. When we use openssl dynamic library, we cannot guarantee that the version of openssl officially maintained by openresty is finally used.

tzssangglass commented 2 years ago

where is not used?

I see that some of the scripts use the openresty-opsneel, e.g.: https://github.com/api7/apisix-build-tools/blob/a386c7e7c8e1576231d512c7b92e807c7bbbeee1/build-apisix-base-debug-centos7.sh#L7

soulbird commented 2 years ago

build-apisix-base-debug-centos7.sh

I am not centos, maybe we should add in build-apisix-base.sh

tzssangglass commented 2 years ago

I am not centos, maybe we should add in build-apisix-base.sh

build-apisix-base.sh is used by build-apisix-base-debug-centos7.sh

Line 7 in a386c7e

see: https://github.com/api7/apisix-build-tools/blob/a386c7e7c8e1576231d512c7b92e807c7bbbeee1/build-apisix-base-debug-centos7.sh#L19

I think the job of specifying the openssl version should be done in build-apisix-base-debug-xxx.sh, e.g. https://github.com/tzssangglass/apisix-build-tools/blob/3bcf4f5bd5773d11f3bbec006396032edb53e706/build-apisix-base-maoos_x86_64.sh#L14

soulbird commented 2 years ago

I am not centos, maybe we should add in build-apisix-base.sh

build-apisix-base.sh is used by build-apisix-base-debug-centos7.sh

Line 7 in a386c7e

see:

https://github.com/api7/apisix-build-tools/blob/a386c7e7c8e1576231d512c7b92e807c7bbbeee1/build-apisix-base-debug-centos7.sh#L19

I think the job of specifying the openssl version should be done in build-apisix-base-debug-xxx.sh, e.g. https://github.com/tzssangglass/apisix-build-tools/blob/3bcf4f5bd5773d11f3bbec006396032edb53e706/build-apisix-base-maoos_x86_64.sh#L14

LGTM. I will do it like this