search

apis-is / apis

Making data readily available to anyone interested
https://apis.is
MIT License
162 stars 64 forks source link

raven@2.4.2 alert: no DSN provided, error reporting disabled #470

Closed sse87 closed 5 years ago

sse87 commented 6 years ago

I can see it's when SENTRY_URL is undefined or a valid sentry dsn string. It's not a bug just noise when running dev and test. I thought it was in used by CircleCI but I can see it's also displayed there: image

Is it just outdated code so it's OK to remove it or at least hide it by not run raven install when it's undefined?

MiniGod commented 6 years ago

We use this in production only, so checking if it is set is probably a good idea!

MiniGod commented 5 years ago

Fixed in #471