apjanke / octave-testify

New BIST (Built-In Self Test) functions for GNU Octave
GNU General Public License v3.0
4 stars 2 forks source link

BistRunner temp dir collision #71

Closed apjanke closed 5 years ago

apjanke commented 5 years ago

Whoops. Looks like the temporary files are only uniquified with a timestamp precise to the second. If you have multiple Octave processes running tests, they can collide.


  <Octave/m>/plot/draw/light.m ................................ PASS      2/2
  <Octave/m>/plot/draw/line.m .................................error: rm_rf: Failed deleting dir /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/octave/testify/BistRunner/bist-run-2019-04-19_17-03-54: No such file or directory

Log location: /Users/janke/octave/testify/logs/test-suite/testsuite-angharad.local-macOS-20190419_165839
error: called from
    rm_rf at line 123 column 11
    run_tests at line 448 column 9
    run_tests at line 331 column 17
    __run_test_suite2__ at line 58 column 13
>>

Throw in some random salt and/or a PID in the temp dir to ensure uniqueness.