search

apocas / docker-modem

Docker Remote API network stack driver.
Apache License 2.0
234 stars 112 forks source link

Multiplex over ssh #126

Open mcary opened 4 years ago

mcary commented 4 years ago

Does this seem like a useful change for docker-modem? For my purposes, it means both a performance boost and improved ability to use docker-modem (and dockerode) without running ssh-agent.

I'm building on some ideas from this comment about running without ssh-agent.

apocas commented 3 years ago

Would love to see more input about this change. We also need to add tests via SSH. (idea: use dockerode's test suite via SSH)

mcary commented 3 years ago

@apocas: There is some additional detail regarding rationale in each of the commit messages. Does that help meet your request for more input about the change?

Also, I'm a little confused about the test suite idea to use dockerode's test suite via SSH. Are you suggesting that docker-modem should gain a dependency on dockerode and run dockerode's suite with a docker-modem configuration that uses SSH? (Normally I would expect people to want to avoid such a circular dependency.) What should the suite connect to over SSH, a docker host configured by Vagrant or something? I noticed the existing test coverage for docker-modem seems to focus mostly on how configuration is applied, not on how docker-modem actually communicates, so following the precedent of tests for the HTTP agents wouldn't seem to accomplish the goal of using dockerode's suite (unless I'm missing part of how docker-modem is tested when I look at the test/ directory of docker-modem?).