search

apognu / tuigreet

Graphical console greeter for greetd
GNU General Public License v3.0
992 stars 45 forks source link

long wait time after entering password in 0.7.1 #40

Closed hossamdash closed 3 years ago

hossamdash commented 3 years ago

my screen shows a blinking "-" symbol on a black screen for about 10 seconds after entering password and pressing enter. downgrading to 0.6.1 solves the problem. here's my /etc/greetd/config.toml for reference. I'm using the package from AUR

[terminal]
# The VT to run the greeter on. Can be "next", "current" or a number
# designating the VT.
vt = 1

# The default session, also known as the greeter.
[default_session]

# `agreety` is the bundled agetty/login-lookalike. You can replace `$SHELL`
# with whatever you want started, such as `sway`.
command = "tuigreet --issue --time --remember --remember-session"

# The user to run the command as. The privileges this user must have depends
# on the greeter. A graphical greeter may for example require the user to be
# in the `video` group.
user = "greeter"
apognu commented 3 years ago

Sorry I've taken some time to come back to you, I had some trouble pinpointing the exact issue here.

Apparently, reading from stdin is not a good neighbor to Tokio's async. The "delay" was actually the input process still waiting forever for another keypress. greetd finally killed tuigreet after 5 seconds (to prevent exactly this), which allowed your command to be run.

This is not a trivial change, I have to change the terminal backend I use, but I'm close to a fix (I think).

apognu commented 3 years ago

@hossamdash Are you able to give one of these artifacts a try? The issue seems to be fixed on my side, but I'd like to give it some testing before merging it into master.

hossamdash commented 3 years ago

@apognu I tried your latest dev branch artifacts and the issue seems to be fixed, now the time is more like 1.8 seconds which is similar to what i was getting with ly. thanks for solving the issue so quick and for the awesome work with this tool :D.

apognu commented 3 years ago

Yeah, from my tests, the leftover delay might actually come from greetd and the initialization time of whatever you run.

I'll do more testing tomorrow and keep using this version for a while before I can be confident merging it into master.

I'll close this when it is merged.

apognu commented 3 years ago

This was merged into master and will be part of 0.8.0.