search

apollo-lhc / cm_mcu

Microcontroller source code for the APOLLO blade for the CMS tracker HL-LHC upgrade.
MIT License
2 stars 2 forks source link

MCU FW VER in stream of data sent to Zynq can be wrong #206

Closed pwittich closed 3 months ago

pwittich commented 5 months ago

Describe the bug the parsing code on the MCU searches for a semver-like version, i.e., v#, and that can get confused if the branch name contains that.

To Reproduce

>readstring PL_MEM_CM.MCU_FW_VER 
PL_MEM_CM.MCU_FW_VER: v2) list-11-ga5c8a0
>uart_cmd CM_1 version
Recieved:
DEBUG build
commit date 2024-01-15 18:19:57 -0500   (HEAD, origin/dev_packerv2, dev_packerv2) list-11-ga5c8a04-dirty built at 13:17:58, Feb  2 2024.

Expected behavior a reasonable tag. I'm confused about the tag above, pretty sure list is nota tag?

pwittich commented 5 months ago

It turns out that someone (presumably me) had added "list" to the list of tags. Since corrected. but comment on the "v2" in the branch name continues.

pwittich commented 3 months ago

I am going to close this since it seems like a very low priority bug to fix.