search

apollo-server-integrations / apollo-server-integration-hapi

MIT License
3 stars 3 forks source link

Pass TContext type argument to ApolloServer #45

Closed kevinbgreene closed 1 year ago

kevinbgreene commented 1 year ago

Context

ApolloServer is generic on the type of the context, constrained by extends BaseContext. HapiApolloPluginOptions takes the context type as a generic type parameter, but does not pass this to ApolloServer, meaning when trying to use a custom context TypeScript compilation errors can occur.

Changes

Pass TContext to ApolloServer in HapiApolloPluginOptions.

trevor-scheer commented 1 year ago

Thanks! @kevinbgreene would you please run npx changeset and follow the prompts for a patch release?

kevinbgreene commented 1 year ago

Thanks! @kevinbgreene would you please run npx changeset and follow the prompts for a patch release?

Added

kevinbgreene commented 1 year ago

@trevor-scheer Friendly bump.

trevor-scheer commented 1 year ago

@kevinbgreene I pushed to your branch to rebase / fix some funky changelog stuff (there were two) and also to trigger the CI pipeline since it was previously disabled for forks. Thanks! I'll get this patch released right away.